Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff output is not working correctly on Windows #202

Open
MonaAghili opened this issue Jan 19, 2025 · 5 comments
Open

Diff output is not working correctly on Windows #202

MonaAghili opened this issue Jan 19, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@MonaAghili
Copy link

MonaAghili commented Jan 19, 2025

Hello, We're having an issue with displaying changes in a file. As shown in the video, the components are installed from Mishka chelekom, and the project is up to date with the latest master branch. I make some changes to a component in my project, and then I pull updates from the master. Naturally, the changes I made differ from what's in the master.

In the macOS video, we can see that only the parts of the file that were modified are highlighted in green and red, clearly showing what was added or removed. However, on Windows, as seen in the video, the entire file gets printed twice in the command line instead of just showing the differences.

This inconsistency in Windows creates additional challenges in tracking file changes effectively.

MAC

diff_mac.mp4

Windows:

Diff_Win.mp4

** Runtime

igniter: 0.5.8
Elixir: 1.18.1
Erlang: 27
OS: Windows 11

CC: @shahryarjb

@MonaAghili MonaAghili added the bug Something isn't working label Jan 19, 2025
@zachdaniel
Copy link
Contributor

Can you try the latest versions and see if there is any difference?

@MonaAghili
Copy link
Author

Hello dear @zachdaniel
I closed the other issue because it has been resolved. However, this issue on Windows still persists.

@zachdaniel
Copy link
Contributor

Interesting that is surprising. I would have expected them to have been fixed with the same thing. Could you please try to reproduce with a minimal igniter task? To ensure that this isn't something related to your usage specifically?

@MonaAghili
Copy link
Author

Interesting that is surprising. I would have expected them to have been fixed with the same thing. Could you please try to reproduce with a minimal igniter task? To ensure that this isn't something related to your usage specifically?

Hi I installed a component and made a few adjustments on both macOS and Windows to demonstrate the output differences. On macOS everything works perfectly! but on Windows, the diffs still don't show up.

As you can see, I made the same adjustments on both systems and in the videos you can see the differences in the outputs

Windows

diff_win.mp4

MAC

igi_mac.mp4

@shahryarjb created this setup to test these issues, so I installed it in a new project. You can find it here: igiwindow.

@shahryarjb
Copy link
Contributor

Dear @zachdaniel, the name "Task Mishka" might be a bit confusing, but the test @MonaAghili conducted has been reproduced on a project with less than 30-40 lines of code, which has also been shared above.

https://github.com/shahryarjb/igiwindow

The entire task was that we created a file from a template. Then, we made just a small change in the document, like adding a semicolon. You can see on Windows that it's reloading the entire file.

Thank you in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants