Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GT info to the VCFs #43

Open
shinlin77 opened this issue Apr 1, 2022 · 11 comments
Open

add GT info to the VCFs #43

shinlin77 opened this issue Apr 1, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@shinlin77
Copy link

I've successfully run the example. I don't understand the output

out/merged_snp/jurkat_chr1/final.tsv.gz

What is the final call? And is what should I use as the measure of confidence?

Thanks.

@aryarm
Copy link
Owner

aryarm commented Apr 2, 2022

Hi @shinlin77 ,

Thanks for your interest in VarCA! I've attached responses to each portion of your question below.


out/merged_snp/jurkat_chr1/final.tsv.gz

I think you're referring to the output of the prepare subworkflow, which is not the final output of the entire pipeline. After the prepare subworkflow, VarCA automatically runs the classify subworkflow.

What is the final call? And is what should I use as the measure of confidence?

VCFs containing the final calls as well as QUAL scores with a measure of confidence for each call are generated at the end of the classify subworkflow. That output is described here. Here's the path for the jurkat_chr1 sample:

out/classify/jurkat_chr1_snp/final.vcf.gz

@shinlin77
Copy link
Author

Thanks for getting back to me. That makes a lot more sense. One additional question, though. How are heterozygous calls designated? In the example, it seems like all the ALT are homozygous.

@aryarm
Copy link
Owner

aryarm commented Apr 2, 2022

The VCFs produced by VarCA lack the genotype (GT) field (see #11)

In theory, it should be possible to have 2vcf.py add that information to the VCFs, since I think most of the individual variant callers have it. But it might take a bit of a refactor, and I just haven't had the time to implement that.

Is that a feature that you'd like to have?

@shinlin77
Copy link
Author

That would be wonderful. The concept of your program should be useful for the community, but this feature would make it truly practical.

@aryarm
Copy link
Owner

aryarm commented Apr 4, 2022

ok, we'll see if I have some time for this

One caveat to this is that a variant may be incorrectly called homozygous (when, in fact, it's actually heterozygous) in situations where only one of the alleles has open chromatin
In other words, the GT info may be incorrect in loci with allele-specific open chromatin

Does that matter to you?

@shinlin77
Copy link
Author

shinlin77 commented Apr 4, 2022 via email

@aryarm
Copy link
Owner

aryarm commented Apr 4, 2022

you can quantify how often that happens, right?

In theory, it should be possible. In practice, it might be difficult. We could compare the scATAC-seq variants to variants from WGS, but there could be other reasons that the two would differ from each other besides allele-specific open chromatin. So we would have to come up with some measure (and a threshold on that measure) for detecting allele-specific open chromatin, and then filter for sites that pass the threshold.

@aryarm aryarm self-assigned this Apr 4, 2022
@aryarm aryarm added the enhancement New feature or request label Apr 4, 2022
@aryarm aryarm added this to the VarCA v2.1.0 milestone Apr 4, 2022
@shinlin77
Copy link
Author

shinlin77 commented Apr 11, 2022 via email

@aryarm
Copy link
Owner

aryarm commented Apr 16, 2022

Hi @shinlin77 ,

I agree that it would be good to know. Somebody should do it. But developing a method to perform a test for allele specific chromatin is probably a whole project on its own. After all, testing for allele specific expression is kinda its own sub-field. I'm sorry, but I think that specific request is one that I do not personally have the bandwidth to implement within the foreseeable future.

But nonetheless, I'm going to keep this issue open to track progress on your request to add GT info to the VCFs. Afterwards, I will probably add a warning in the documentation explaining this situation and cautioning that the GT info may be inaccurate and should be ignored by the conventual user unless they have a way to account for allele specific open chromatin.

@aryarm aryarm changed the title what does output mean? add GT info to the VCFs Apr 16, 2022
@aryarm
Copy link
Owner

aryarm commented Apr 16, 2022

(I'm just renaming the title of the issue to reflect its new purpose.)

If you have any other feature requests, kindly submit them in a new issue. Or, if you have a question or discussion item, you can add it to the Discussions tab.

@shinlin77
Copy link
Author

shinlin77 commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants