Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search docs to reflect changes to institutional search #236

Closed
anvit opened this issue Oct 19, 2023 · 2 comments · Fixed by #241
Closed

Update search docs to reflect changes to institutional search #236

anvit opened this issue Oct 19, 2023 · 2 comments · Fixed by #241
Assignees
Labels
user manual The issue affects content in the User manual
Milestone

Comments

@anvit
Copy link
Contributor

anvit commented Oct 19, 2023

See artefactual/atom#1635.
Changes required at: https://accesstomemory.org/en/docs/2.7/user-manual/access-content/search-atom/#search-box-delimiters

@anvit anvit added user manual The issue affects content in the User manual new content This issue will add a new section or page to the documentation and removed new content This issue will add a new section or page to the documentation labels Oct 19, 2023
@anvit anvit self-assigned this Oct 19, 2023
@fiver-watson
Copy link
Contributor

I mean....

Important note: ALL the documentation images still show the old BS2 user interface. Since you are ultimately changing the BS5 institutional search feature to be almost the same as it was in BS2, it seems that the real big task for 2.8 is to update all the screenshots to show BS5 elements.

This will be a big undertaking, so since 2.8 will make BS5 the default and deprecate (but keep) BS2, I would suggest that it makes sense for someone to start on this now / soon, as picking away at it may take until the 2.9 release anyway...

Just a thought!

@anvit
Copy link
Contributor Author

anvit commented Oct 19, 2023

We'd actually decided to not go with trying to mirror the BS2 search bar due to some accessibility concerns when using keyboard navigation, and just decided to make the Global Search option the default. But yeah, point taken about updating the docs showing BS5 screenshots across all pages. Let me create another issue for that and I'll try to get started on it next week!

anvit added a commit that referenced this issue Oct 23, 2023
Update the docs to remove references to having the institutional search
being the default option, since AtoM now defaults to global search.
@anvit anvit added this to the 2.8 milestone Oct 23, 2023
@anvit anvit linked a pull request Oct 23, 2023 that will close this issue
anvit added a commit that referenced this issue Oct 25, 2023
Update the docs to remove references to having the institutional search
being the default option, since AtoM now defaults to global search.
anvit added a commit that referenced this issue Nov 20, 2023
Update the docs to remove references to having the institutional search
being the default option, since AtoM now defaults to global search.
@anvit anvit closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user manual The issue affects content in the User manual
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants