Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using IMDSv2, turn on encryption at rest #35

Open
yi2020 opened this issue Dec 21, 2020 · 1 comment
Open

Switch to using IMDSv2, turn on encryption at rest #35

yi2020 opened this issue Dec 21, 2020 · 1 comment

Comments

@yi2020
Copy link

yi2020 commented Dec 21, 2020

Ran Cloudrail against the TF here with basic parameters and found a couple of issues.

  1. module.ecs.module.ecs_instances.aws_launch_configuration.launch is not using IMDSv2 (metadata_options). The issue can be important because traffic to the ECS can be direct, and if there's a web app running there, someone could access the metadata service.

  2. The log groups are not encrypted (module.ecs.module.ecs_instances.aws_cloudwatch_log_group) and EBS is not encrypted at rest (for module.ecs.module.ecs_instances.aws_launch_configuration). Generally not a biggie, but if used in certain regulated environments, it can be a lot of "fun" to fix this after the stack is deployed.

I can take on a fixing both issues and opening a PR, please let me know if this is of interest.

@arminc
Copy link
Owner

arminc commented Dec 24, 2020

It would be interesting to have this, if you can create a fix and add the info to the documentation that would be very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants