Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No overlay config shown #343

Closed
1 task done
EvilOlaf opened this issue Dec 27, 2024 · 6 comments
Closed
1 task done

[Bug]: No overlay config shown #343

EvilOlaf opened this issue Dec 27, 2024 · 6 comments
Labels
Bug Something isn't working as it should

Comments

@EvilOlaf
Copy link
Member

What happened?

Station P1 Armbian 25.02.0-trunk user-built 6.13.0-rc4-edge-rockchip64 (Debian bookworm)
armbian-config version 25.2.0-trunk.229.1227.143514 (upgraded right before opening this report)
https://paste.next.armbian.com/qemubiluce

When navigating to System - Kernel the option for overlays is missing. Only SY201 and SY204 are shown.
Though overlays are available:

root@station-p1:/boot/dtb/rockchip/overlay# ls|grep rk3399
rockchip-rk3399-dwc3-0-host.dtbo
rockchip-rk3399-i2c7.dtbo
rockchip-rk3399-i2c8.dtbo
rockchip-rk3399-opp-2ghz.dtbo
rockchip-rk3399-pcie-gen2.dtbo
rockchip-rk3399-spi-jedec-nor.dtbo
rockchip-rk3399-spi-spidev.dtbo
rockchip-rk3399-uart4.dtbo
rockchip-rk3399-w1-gpio.dtbo

This seems to affect other boards too. Just right now a person in Discord reported this with Jetson Nano

How to reproduce?

Get a Station P1 or Jetson Nano and try enabling overlays via armbian-config

On which host OS are you running the build script and observing this problem?

Debian 12 Bookworm

Code of Conduct

  • I agree to follow this project's Code of Conduct
@EvilOlaf EvilOlaf added the Bug Something isn't working as it should label Dec 27, 2024
@aperture147
Copy link

Confirmed. Happening to me with Armbian 23.8.1 Bookworm minimal on Jetson Nano

@Tearran
Copy link
Member

Tearran commented Dec 28, 2024

Works on meson64
./bin/armbian-config --cmd SY210
./bin/armbian-config --api manage_dtoverlays

grep 'LINUXFAMILY' /etc/armbian-release | sed 's/^LINUXFAMILY=//g

meson64

Dose the command

grep 'LINUXFAMILY' /etc/armbian-release | sed 's/^LINUXFAMILY=//g'

match the any of the related "$LINUXFAMILY" == "*" `

[[ "$LINUXFAMILY" == "rockchip64" || "$LINUXFAMILY" == "rk3399" || "$LINUXFAMILY" == "rockchip-rk3588" || "$LINUXFAMILY" == "rk35xx" ]] && overlaydir="/boot/dtb/rockchip/overlay";

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Dec 28, 2024

Yes, matches rockchip64.
Might the folder name be the culprit? It is named rockchiponly.

Calling directly with armbian-config --cmd SY210 brings up the menu correctly.
Still obviously fails to apply changes since Station P1 uses extlinux instead of plain armbianEnv.txt

@Tearran
Copy link
Member

Tearran commented Dec 28, 2024

"obviously fails to apply changes since Station P1 uses extlinux instead of plain armbianEnv.txt"

Not so obvious, thank you for sharing it was helpful 💯. Looking further, we should add overlay support for extlinux.conf.

"When navigating to System - Kernel the option for overlays is missing. Only SY201 and SY204 are shown."

This is the expected behavior in this case, will only show if compatible, as we currently only have armbianEnv.txt compatibility. Should not show.

Reference: config.system.json

@EvilOlaf, in the context of code, this is a "[feature request]"—an oversight perhaps :), but it is still a "[feature request]" nevertheless.

"Calling directly with armbian-config --cmd SY210 brings up the menu correctly."

I can see perhaps brings up the menu correctly being a bug and will continue that on a similar issue #344.

@EvilOlaf
Copy link
Member Author

Looking further, we should add overlay support for extlinux.conf.

Not sure if its worth the effort since barely any images are using extlinux. I think those who are are all csc?

This is the expected behavior in this case, will only show if compatible, as we currently only have armbianEnv.txt compatibility. Should not show.

Ah okay, Didn't know the show-up depends basically on armbianEnv being there.

in the context of code, this is a "[feature request]"—an oversight perhaps :),

Yes. The question now is to either mangle this issue report or simply create a new one requesting support for extlinux ;). Your call.

@Tearran
Copy link
Member

Tearran commented Dec 29, 2024

Not sure if its worth the effort since barely any images are using extlinux. I think those who are are all csc?

Agreed closing.

@Tearran Tearran closed this as completed Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as it should
Projects
None yet
Development

No branches or pull requests

3 participants