Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Requests/Help Wanted #119

Open
cregkly opened this issue Jan 21, 2020 · 9 comments
Open

Maintenance Requests/Help Wanted #119

cregkly opened this issue Jan 21, 2020 · 9 comments

Comments

@cregkly
Copy link

cregkly commented Jan 21, 2020

This is currently the most popular SES forwarding lambda available. Every article on this topic links to this project.

However there has been no activity from @arithmetric in over a year, with many pull requests going unanswered. There seems to be quite a bit of activity and it seems that everyone (myself included) is just forking and making their own changes.

@arithmetric are you still interested in being the owner?

This page has some good ideas. Setting this up as a project with multiple administrators might be a good solution. Assuming Joe doesn't want to continue. Thoughts?

I am using this script in production for a business, so have an interest in keeping this project alive and can spend some work time on it.

@ccjmne
Copy link
Contributor

ccjmne commented Jan 21, 2020

As a fellow forker/unanswered-PR-author, I also would be in favour of having it managed by the community.

I have enough time and enthusiasm to keep it working, and I would definitely be interested in maintaining this project!

If it turns out that @arithmetric indeed would want to delegate some responsibilities, I'm okay with simply assigning more maintainers to this project.

However, he seems to have very little activity on GitHub and I'm not sure how we could get in touch with him (other than using the @-mention here).
Perhaps we would need to use/create yet another branch and collaborate there, but the problem becomes about redirecting people to the "right" place.

A simple notice at the top of the main README on this repo may be enough, but would still require Joe's involvement...

As I see it, we probably need to get through to him.

@3boysdad
Copy link

...this would be nice...this library needs some several bug fixes and feature enhancements, like file attachment support, update to typescript... i'm sure someone has done it in the various forks.

@ccjmne
Copy link
Contributor

ccjmne commented Jan 21, 2020

Alternatively, we may just set up a simple GitHub organisation that owns this repo/a fork, it's a little bit more formal but doesn't cost anything and has the advantages of being:

  • less reliant on any single owner
  • more easily found and shared (maybe?)

Either way, I'm very much up for giving this project a second life.

@3boysdad
Copy link

let's give the original owner some time to respond...if there's no response by Monday next week? that might be the best approach to the problem.

@arithmetric
Copy link
Owner

Hi, thanks for your interest in this project!

I acknowledge that I haven't reviewed many of the PRs from the last year, and I can take action on the most straightforward ones (bug fixes, dependency updates, documentation, etc.). Please point me to those that you see as most important.

I'd welcome help maintaining the project. In general I find it most time consuming to review/test PRs and respond to issues, so those would be ideal areas for contributions.

Overall my approach with this project has been to keep it simple and aim to meet the most general requirements. I've tended to be conservative in the changes accepted to keep the core working as users expect. I think it's healthy that people fork it to add functionality that serves their needs. That said, I'm always happy to consider changes that will benefit most users.

@dangarthwaite
Copy link

A client really needs this supported: #40

@arithmetric arithmetric changed the title Abandoned Project Maintenance Requests/Help Wanted Jul 1, 2020
@arithmetric arithmetric pinned this issue Jul 1, 2020
@arithmetric
Copy link
Owner

Hi all,

I've merged a number of the open pull requests and released the new version 5.0.0. See the version's release notes: https://github.com/arithmetric/aws-lambda-ses-forwarder/releases/tag/v5.0.0

There are two other pull requests that seem especially important for handling emails from a variety of senders/in a variety of formats:

I could use help getting these PRs ready to be merged. I've noted a few follow ups needed on #108, and there could be some conflicts between #108 and #114 that I haven't been able to evaluate. Please feel free to adopt these PRs and get them over the finish line!

Finally, I've renamed and pinned this issue thread to use for discussing maintenance requests and areas to contribute.

@dangarthwaite FYI - Version 5.0.0 includes the change from pull request #40.

@chrismarcellino
Copy link

chrismarcellino commented Dec 13, 2020

In case anyone prefers another Python option, there is a derivative I posted here with most of these requested improvements (sorry I am no good at js):

https://github.com/chrismarcellino/lambda-ses-email-forwarder

(i.e. improved from address parsing, oversized email bounce sending, and other improvements detailed in the README.md).

@kjpgit
Copy link

kjpgit commented Apr 16, 2021

@chrismarcellino I was inspired by yours and wrote another Python one. It has clean code and unit tests.
https://github.com/kjpgit/HumbleForwarder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants