Some resources cannot use success/failure conditions at all due to bug in UnsafeGuessKindToResource

[wreed4]

Checklist

• Double-checked my configuration.
• Tested using the latest version.
• Used the Emissary executor.

Summary

Due to this bug kubernetes/client-go#1082
And the usage of this function here:

argo-workflows/workflow/executor/resource.go

Line 80 in 74cdf5d

pluralGVR, _ := meta.UnsafeGuessKindToResource(gvk)

certain custom resources will get the incorrect plural and fail when using a success/failure condition.

gateway is one such word.

The relevant log from the executor is here

time="2022-08-18T19:55:50.232Z" level=info msg="Resource: kaas-egress-ip/eipgateway.egressips.acquia.io/eipgateway-post-sync-wf-1660852548-7f461cfc5b5e. SelfLink: apis/egressips.acquia.io/v1alpha1/namespaces/kaas-egress-ip/eipgatewaies/eipgateway-post-sync-wf-1660852548-7f461cfc5b5e"
time="2022-08-18T19:55:50.232Z" level=info msg="Waiting for conditions: status.eipAssignments.1.state==ASSIGNED,status.eipAssignments.2.state==ASSIGNED"
time="2022-08-18T19:55:50.240Z" level=info msg="Get eipgatewaies 403"
time="2022-08-18T19:55:50.240Z" level=warning msg="Non-transient error: eipgatewaies.egressips.acquia.io \"eipgateway-post-sync-wf-1660852548-7f461cfc5b5e\" is forbidden: User \"system:serviceaccount:kaas-egress-ip:eip-post-sync-tests\" cannot get resource \"eipgatewaies\" in API group \"egressips.acquia.io\" in the namespace \"kaas-egress-ip\""

Diagnostics

You'll need a CRD to test this, but anything ending in gateway will trigger this bug.

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

[terrytangyuan]

I don't think there's any better way than UnsafeGuessKindToResource to can do this. This should be a bug in client-go instead.

[wreed4]

an optional field could be provided to specify the plural explicitly on the resource template as a workaround. That seems like a simple option that would be fairly easy to ignore in future versions if/when this bug gets fixed.

Alternatively, and this might be extreme, the plural is stored on the CRD. That could be looked up and parsed. That feels pretty hacky though.

[wreed4]

This seems like another reasonable work around

kubernetes/kubernetes#110053 (comment)

[wreed4]

Threw up a test PR. Seems to work locally. #9396