Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with extra registry parameter in helm value. #974

Open
crazy-canux opened this issue Dec 19, 2024 · 3 comments
Open

Not working with extra registry parameter in helm value. #974

crazy-canux opened this issue Dec 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@crazy-canux
Copy link

crazy-canux commented Dec 19, 2024

Describe the bug

when there are three parameters in helm value, it's not working.

To Reproduce

    argocd-image-updater.argoproj.io/image-list: myalias=my-registry/my-repository:latest
    argocd-image-updater.argoproj.io/myalias.update-strategy: digest
    argocd-image-updater.argoproj.io/myalias.force-update: true
   argocd-image-updater.argoproj.io/myalias.helm.image-name: backstage.image.repository
   argocd-image-updater.argoproj.io/myalias.helm.image-tag: backstage.image.tag

in helm value:

    backstage:
        image:
            registry:
            repository:
            tag:

Expected behavior
update image in argocd.

Additional context
without image-name and image-tag annotation, will get another issue.
new image detected, but not updated in argocd.

time="2024-12-18T09:57:48Z" level=info msg="Successfully updated image 'my-registry/my-repositor@dummy' to 'my-registry/my-repository@sha256:2defa431dcf22d2baf5d4b6d8241caf12d7ad4f09a9168f65327bd80af6e235f', but pending spec update (dry run=false)" alias=myalias application=test image_name=my-repository image_tag=dummy registry=my-registry

Version
0.15.0

Logs

with image-name and image-tag annotation, the image url will include registry which not right.

Failed to pull image "my-registry/my-registry/my-repository:latest@sha256:292638896047d855da3c2f531ccecd0e172a06344840bebf5c2d7d59c36c2e08": rpc error: code = NotFound desc = failed to pull and unpack image "my-registry/my-registry/my-repository@sha256:292638896047d855da3c2f531ccecd0e172a06344840bebf5c2d7d59c36c2e08": failed to copy: httpReadSeeker: failed open: could not fetch content descriptor sha256:292638896047d855da3c2f531ccecd0e172a06344840bebf5c2d7d59c36c2e08 (application/octet-stream) from remote: not found

@crazy-canux crazy-canux added the bug Something isn't working label Dec 19, 2024
@crazy-canux crazy-canux changed the title Not working with registry parameter. Not working with extra registry parameter in helm value. Dec 19, 2024
@chengfang
Copy link
Collaborator

Please upgrade to the patch release 0.15.1, which contains important bug fixes. It may not fix this issue but will prevent future errors.

@chengfang
Copy link
Collaborator

Without this backstage.image.registry parameter in helm values, does everything work fine?

@leezhihui
Copy link

removed backstage.image.repository and it works, so there has default ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants