Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent releases break kustomize when tracking latest with digest #1001

Open
Sovietaced opened this issue Jan 8, 2025 · 3 comments
Open

Recent releases break kustomize when tracking latest with digest #1001

Sovietaced opened this issue Jan 8, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@Sovietaced
Copy link
Contributor

Sovietaced commented Jan 8, 2025

Describe the bug

We recently upgraded the Argo CD Image Updater (from an old fork off of v0.13) and found a regression where Kustomize patches were broken and Argo CD was trying to synchronize the image defined in the original deployment manifest.

My suspicion is that the way the image is now written to the kustomize patch is not compatible with Argo CD (or at least the version that we're running which is 2.8).

This is the change that we noticed in the image tag. It now seems to include the immutable tag as well as the digest.

git diff

kustomize:
  images:
 (-) - <redacted>_svc@sha256:21e88fb9c107f10ad274a7703a6d56cf47e737cc3981c36c1a73ac31a388ca16 # (old)
 (+) - <redacted>_svc:latest@sha256:df8c34bb660b52b645c7df13431b41df65b6900db71b9162d31f6e7d1bf20fcc # (new)

Additional context
We are using Argo CD Server v2.8.0
We are using the instructions listed here: https://argocd-image-updater.readthedocs.io/en/release-0.15/configuration/images/#tracking-an-images-latest-tag

@Sovietaced Sovietaced added the bug Something isn't working label Jan 8, 2025
@Sovietaced
Copy link
Contributor Author

This may be related: kubernetes-sigs/kustomize#4713

@Sovietaced Sovietaced changed the title Recent releases break kustomize Recent releases break kustomize when tracking latest with digest Jan 8, 2025
@chengfang
Copy link
Collaborator

the kustomize issue you mentioned above was fixed in kustomize v5.4.0. I think more recent versions of argo-cd should already have this fixed version or later. In the current argo-cd master branch, the kustomize version is 5.4.3:

https://github.com/argoproj/argo-cd/blob/master/hack/tool-versions.sh#L17

which image-updater version are you using? The latest is 0.15.2 should be used if you're using 0.15.x

@Sovietaced
Copy link
Contributor Author

the kustomize issue you mentioned above was fixed in kustomize v5.4.0. I think more recent versions of argo-cd should already have this fixed version or later. In the current argo-cd master branch, the kustomize version is 5.4.3:

https://github.com/argoproj/argo-cd/blob/master/hack/tool-versions.sh#L17

which image-updater version are you using? The latest is 0.15.2 should be used if you're using 0.15.x

Thank you, I will try a newer version of Argo CD server. I was using the latest image-updater version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants