Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

feat: migrate DELETE /api/users/:user_id endpoint to DELETE /api/v1/users/:user_id #148

Merged

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented May 7, 2024

Description

This PR migrate adds a new endpoint DELETE /api/v1/users/:user_id allowing the deletion of users using API v1.

Closes #147

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

  • Adding new tests and checking that old tests for API v0 pass with API v1 implementation.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon May 7, 2024 14:06
Base automatically changed from feat/migrate-create-user-to-api-v1 to feat/move-api-v0-functionality-to-v1 May 13, 2024 09:32
@jfcalvo jfcalvo merged commit 2ab1d19 into feat/move-api-v0-functionality-to-v1 May 13, 2024
10 checks passed
@jfcalvo jfcalvo deleted the feat/migrate-delete-user-to-api-v1 branch May 13, 2024 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Migrate DELETE /api/users/:user_id endpoint to DELETE /api/v1/users/:user_id
2 participants