Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping streaming on file plugins discards all arrays in queue #469

Open
MarkRivers opened this issue Feb 21, 2021 · 0 comments
Open

Stopping streaming on file plugins discards all arrays in queue #469

MarkRivers opened this issue Feb 21, 2021 · 0 comments

Comments

@MarkRivers
Copy link
Member

If a file plugin is in streaming mode then when streaming is stopped (setting Capture=0) any NDArrays currently in the queue will be discarded. I don't believe this is the desired behavior.

Example:

  • User is viewing camera images collecting at 100 frames/s in a viewer which can keep up with the image rate.
  • HDF5 file writer is streaming data to disk, which cannot keep up at 100 frames/s. User has set a large queue to buffer images because of this.
  • User sees the end of the interesting action, and stops the HDF5 file plugin, expecting that it will save all frames up until the time when the file plugin was stopped.
  • This is not what happens, in fact all frames in the queue are discarded, and some of the interesting action has been lost.

I think setting Capture=0 should not immediately close the file, it should first empty the queue and then close the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant