-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded ":" in request file #343
Comments
These are the template files in ADCore that hardcode ":".
I have removed the search results where the ":" was not part of the record name, i.e. info tags, etc. These are the .req files that hardcode a ":"
Presumably you would also like the .template files to be changed? |
I missed the templates that you found. If it is too much of a hassle to deal with at this moment, I can rely on my local changes to get the job done and this can wait until better time. FYI, I have changed the NDStats_settings.req to hold:
and my auto_settings.req has:
|
The only place that hardcodes the ":" delimiter is NDStats_settings.req. Our site has special rules for ":" and therefore I need to change the stock ADCore file to overcome this (currently replacing with "-"):
ADCore/ADApp/Db/NDStats_settings.req
Line 12 in 5122f46
We could remove the offending line from the NDStats_settings.req; let use specify it in its auto_settings.req, or we could introduce a new macro for the "$(R)TS:" and let user set it in the caller.
The text was updated successfully, but these errors were encountered: