Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate BoardListWatchRequest#interrupt from the gRPC API, make it server-streaming only #2283

Closed
3 tasks done
kittaakos opened this issue Aug 28, 2023 · 0 comments · Fixed by #2330
Closed
3 tasks done
Assignees
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

Describe the request

Starting the gRPC equivalent of the board list watch requires CLI consumers to create a bidirectional stream. The only reason for this API is to support canceling the watch operation from the client. It should be sufficient to cancel the watch command by canceling the request via an abort signal.

Please make the following changes to provide a better API:

Thank you!

Describe the current behavior

See the description how it works now.

Arduino CLI version

0.34.0

Operating system

macOS

Operating system version

13.5

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the nightly build
  • My request contains all necessary details
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface labels Aug 28, 2023
@umbynos umbynos added this to the Arduino CLI 1.0 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
3 participants