From 606c6ca7df65555d0dc867eaaddf04ad7ba09c61 Mon Sep 17 00:00:00 2001 From: tpitlik Date: Mon, 1 Jul 2024 09:01:57 +0300 Subject: [PATCH 1/5] Add missing new --- src/Ardalis.Result/Result.Void.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Ardalis.Result/Result.Void.cs b/src/Ardalis.Result/Result.Void.cs index b9ba543..397efb7 100644 --- a/src/Ardalis.Result/Result.Void.cs +++ b/src/Ardalis.Result/Result.Void.cs @@ -69,8 +69,8 @@ public static Result Success(T value, string successMessage) /// A single error message may be provided and will be exposed via the Errors property. /// /// - /// - public static Result Error(string errorMessage) + /// A Result + public new static Result Error(string errorMessage) { return new Result(ResultStatus.Error) { Errors = new[] { errorMessage } }; } From 657aff8b9d15e5710360d1030da8c437fb9981d9 Mon Sep 17 00:00:00 2001 From: tpitlik Date: Mon, 1 Jul 2024 09:02:30 +0300 Subject: [PATCH 2/5] Remove unnecessary braces --- src/Ardalis.Result/Result.Void.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Ardalis.Result/Result.Void.cs b/src/Ardalis.Result/Result.Void.cs index 397efb7..94508ca 100644 --- a/src/Ardalis.Result/Result.Void.cs +++ b/src/Ardalis.Result/Result.Void.cs @@ -21,10 +21,10 @@ public static Result Success() /// Represents a successful operation without return type /// /// Sets the SuccessMessage property - /// A Result> + /// A Result public static Result SuccessWithMessage(string successMessage) { - return new Result() { SuccessMessage = successMessage }; + return new Result { SuccessMessage = successMessage }; } /// From 1ed6a99894d2ba7175c484c7b12b80fd233f502e Mon Sep 17 00:00:00 2001 From: tpitlik Date: Mon, 1 Jul 2024 09:02:54 +0300 Subject: [PATCH 3/5] Fix comments --- src/Ardalis.Result/Result.Void.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Ardalis.Result/Result.Void.cs b/src/Ardalis.Result/Result.Void.cs index 94508ca..a2bb726 100644 --- a/src/Ardalis.Result/Result.Void.cs +++ b/src/Ardalis.Result/Result.Void.cs @@ -173,7 +173,7 @@ public static Result Success(T value, string successMessage) /// such as an edit conflict between multiple concurrent updates. /// See also HTTP 409 Conflict: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#4xx_client_errors /// - /// A Result + /// A Result> public new static Result Conflict() { return new Result(ResultStatus.Conflict); @@ -186,7 +186,7 @@ public static Result Success(T value, string successMessage) /// See also HTTP 409 Conflict: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#4xx_client_errors /// /// A list of string error messages. - /// A Result + /// A Result> public new static Result Conflict(params string[] errorMessages) { return new Result(ResultStatus.Conflict) { Errors = errorMessages }; @@ -204,6 +204,7 @@ public static Result Success(T value, string successMessage) return new Result(ResultStatus.Unavailable) { Errors = errorMessages }; } + /// /// Represents a critical error that occurred during the execution of the service. /// Everything provided by the user was valid, but the service was unable to complete due to an exception. /// See also HTTP 500 Internal Server Error: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_server_errors From 70a1bec009702ca7145604da443cdacd4c3d9093 Mon Sep 17 00:00:00 2001 From: tpitlik Date: Mon, 1 Jul 2024 09:03:06 +0300 Subject: [PATCH 4/5] Fix closing tag --- src/Ardalis.Result.AspNetCore/ResultStatusMap.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Ardalis.Result.AspNetCore/ResultStatusMap.cs b/src/Ardalis.Result.AspNetCore/ResultStatusMap.cs index ff492bc..ab7c7fd 100644 --- a/src/Ardalis.Result.AspNetCore/ResultStatusMap.cs +++ b/src/Ardalis.Result.AspNetCore/ResultStatusMap.cs @@ -50,7 +50,7 @@ public ResultStatusMap AddDefaultMap() /// Allows to override default status code for specific Http Methods /// /// Result Status to map. - /// Default Status Code. + /// Default Status Code. /// A to configure Status Codes for specific Http Methods. public ResultStatusMap For(ResultStatus status, HttpStatusCode defaultStatusCode, Action configure) { From 39970bd61221d0d9e97aeda40c15860baf4f5582 Mon Sep 17 00:00:00 2001 From: tpitlik Date: Mon, 1 Jul 2024 23:01:46 +0300 Subject: [PATCH 5/5] Fix comments --- src/Ardalis.Result/Result.Void.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Ardalis.Result/Result.Void.cs b/src/Ardalis.Result/Result.Void.cs index a2bb726..7209074 100644 --- a/src/Ardalis.Result/Result.Void.cs +++ b/src/Ardalis.Result/Result.Void.cs @@ -173,7 +173,7 @@ public static Result Success(T value, string successMessage) /// such as an edit conflict between multiple concurrent updates. /// See also HTTP 409 Conflict: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#4xx_client_errors /// - /// A Result> + /// A Result public new static Result Conflict() { return new Result(ResultStatus.Conflict); @@ -186,7 +186,7 @@ public static Result Success(T value, string successMessage) /// See also HTTP 409 Conflict: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#4xx_client_errors /// /// A list of string error messages. - /// A Result> + /// A Result public new static Result Conflict(params string[] errorMessages) { return new Result(ResultStatus.Conflict) { Errors = errorMessages };