Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class-based plugins #27

Open
2 of 7 tasks
archangelic opened this issue Sep 5, 2018 · 2 comments
Open
2 of 7 tasks

Class-based plugins #27

archangelic opened this issue Sep 5, 2018 · 2 comments
Assignees
@archangelic
Labels
core issues related to core pinhook functionality such as plugin reloading, internal commands enhancement additional features

Comments

@archangelic
Copy link
Owner

archangelic commented Sep 5, 2018 •
edited
Loading

Implement class-based plugins for all features going forward.

Spec for class-based plugins:

  • ability to give help info back to bot
  • abstract way to send message to calling channel or other channel without returning
  • multiple command and listener support in single class (via method decorators)
  • on_mention decorator
  • cmd and listener plugins should meet these specs
  • ability to inform bot of aliases for commands
  • editable settings (possible work on bot to get this working)
@archangelic archangelic added enhancement additional features Pinhook 2.0.0 labels Sep 5, 2018
@archangelic archangelic self-assigned this Sep 5, 2018
@archangelic archangelic added future Things on the roadmap and removed Pinhook 2.0.0 labels Oct 4, 2018
@Lucidiot Lucidiot mentioned this issue Oct 7, 2018
Open
@archangelic archangelic added Pinhook v2 and removed future Things on the roadmap labels Oct 10, 2018
archangelic added a commit that referenced this issue Oct 12, 2018
@archangelic
first run at class-based plugins laid out in #27
9f2057d
@archangelic archangelic added the core issues related to core pinhook functionality such as plugin reloading, internal commands label Jan 25, 2019
@ixxie
Copy link
Contributor

ixxie commented Feb 24, 2019

Some of the considerations outlined in #60 could be considered when developing class-based plugins.

archangelic added a commit that referenced this issue Sep 12, 2019
@archangelic
preliminary work for class based plugins #27
4ae8753
archangelic added a commit that referenced this issue Sep 18, 2019
@archangelic
add full support for command-based plugins (#27)
9797f73
@archangelic
Copy link
Owner Author

As of 1.8.0, this is in alpha and features of class-based plugins might change significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archangelic archangelic

Labels
core issues related to core pinhook functionality such as plugin reloading, internal commands enhancement additional features
Projects
pinhook
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@archangelic @ixxie