From 470fb8af80d4ddebd0007b7bf7363c9cc778fdbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=20Manuel=20Mari=C3=B1as=20Bascoy?= Date: Fri, 25 Aug 2023 13:38:47 +0200 Subject: [PATCH 1/2] add lowercase conversion for all graphql addresses --- modules/client/src/internal/client/methods.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/client/src/internal/client/methods.ts b/modules/client/src/internal/client/methods.ts index b55eb8e57..baa5de1f7 100644 --- a/modules/client/src/internal/client/methods.ts +++ b/modules/client/src/internal/client/methods.ts @@ -663,7 +663,7 @@ export class ClientMethods extends ClientCore implements IClientMethods { * @memberof ClientMethods */ public async getDao(daoAddressOrEns: string): Promise { - let address = daoAddressOrEns; + let address = daoAddressOrEns.toLowerCase(); if (!isAddress(address)) { await this.web3.ensureOnline(); const provider = this.web3.getProvider(); @@ -979,7 +979,7 @@ export class ClientMethods extends ClientCore implements IClientMethods { type T = { pluginRepo: SubgraphPluginRepo }; const { pluginRepo } = await this.graphql.request({ query, - params: { id: pluginAddress }, + params: { id: pluginAddress.toLowerCase() }, name, }); // get release metadata From a52bcd8f47abb98dfe182ed3c611c867a46137a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=20Manuel=20Mari=C3=B1as=20Bascoy?= Date: Fri, 25 Aug 2023 13:40:21 +0200 Subject: [PATCH 2/2] update changelog --- modules/client/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/client/CHANGELOG.md b/modules/client/CHANGELOG.md index 330bc56f6..28d4c7c25 100644 --- a/modules/client/CHANGELOG.md +++ b/modules/client/CHANGELOG.md @@ -17,6 +17,9 @@ TEMPLATE: --> ## [UPCOMING] +### Changed +- All addresses are now lowercased on subgraph methods +## [1.13.1-rc1] ### Fixes - Support for ERC115Transfers and balances