-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapping Aptos-Wallet-Providers for improving scalability #57
Comments
I think this proposal makes a lot of sense, thoughts @0xmaayan? |
Hi @Yoon-Suji , thanks for posting! Could you elaborate on the proposal? Do you mean any wallet to wrap its property with a On that topic, there is an open PR from a multi-chain wallet that also tries to handle this issue, what are your thoughts about it? #52 |
There are different kind of wallet providers. For injected provider, this suggestion looks good for me. For SDK type, it won't be injected to window or under aptosWallet, so we also need to consider this case. We can refer to https://github.com/solana-labs/wallet-adapter & https://github.com/wallet-standard/wallet-standard. |
Hey guys, thanks for all your comments! @0xmaayan @scottphc @banool
|
Hi, I have a suggestion about the aptos-wallet-adapter.
For now, an AdapterPlugin must be injected directly under the
window
as the same name as wallet to detect the wallet. This way is especially uncomfortable for multi-chain wallets because they have to implement Aptos-only provider with the same name as wallet. (For example, in the case of a WELLDONE Wallet, we try to injectwindow.welldone_aptos
provider to prevent conflicts with other chain's provider in the future. But to do so, we must be named WELLDONE_APTOS)For the above reason, I'd like to suggest below:
window.aptosWallet
orwindow.aptosProvider
, to wrap Aptos Provider objects.window.aptosWallet.welldone
(I think it might also be in array form.)In this way, the provider of the wallet is injected under the
aptosWallet
, so I think it will be convenient to support the aptos-wallet-adapter for multi-chain wallet builder.In this way, I believe the aptos-wallet-adapter will be more scalable and able to support a wider range of wallets.
The text was updated successfully, but these errors were encountered: