You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some extension wallets that have their own RPC provider. So I'd like to suggest that using wallet's RPC URL in the AptosClient so that dapp developer don't need to set up a separate RPC in the SDK to use the wallet's resources.
Motivation
We are working on adding a WELLDONE Wallet to the aptos-wallet-adapter. When implementing the signAndSubmitTransaction method, I have to use AptosClient.generateTransaction() method to convert the payload received by arguments into a transaction form. However, in order to create the AptosClient, I have to put nodeUrl.
Despite having an RPC provider in the wallet, it felt unncessary to use redundant RPC URL. Therefore, I think changing the SDK methods to utilize the wallet's RPC provider would be much more practical for developers.
Pitch
I’d like to first add the request method to PluginProvider in wallet-adapter-core, an interface that communicates with the wallet. This method allows communication with the Aptos node using the RPC url in the wallet.
Then, I'd like to make it possible to use a PluginProvider by adding a constructor option to AptosGeneratedClient. It is anticipated that the wallet's usability would rise. (You don't need to set up a separate RPC in the SDK to use the wallet's resources.)
🚀 Feature Request
There are some extension wallets that have their own RPC provider. So I'd like to suggest that using wallet's RPC URL in the
AptosClient
so that dapp developer don't need to set up a separate RPC in the SDK to use the wallet's resources.Motivation
We are working on adding a WELLDONE Wallet to the
aptos-wallet-adapter
. When implementing thesignAndSubmitTransaction
method, I have to useAptosClient.generateTransaction()
method to convert the payload received by arguments into a transaction form. However, in order to create theAptosClient
, I have to putnodeUrl
.Despite having an RPC provider in the wallet, it felt unncessary to use redundant RPC URL. Therefore, I think changing the SDK methods to utilize the wallet's RPC provider would be much more practical for developers.
Pitch
I’d like to first add the
request
method toPluginProvider
inwallet-adapter-core
, an interface that communicates with the wallet. This method allows communication with the Aptos node using the RPC url in the wallet.Then, I'd like to make it possible to use a
PluginProvider
by adding a constructor option toAptosGeneratedClient
. It is anticipated that the wallet's usability would rise. (You don't need to set up a separate RPC in the SDK to use the wallet's resources.)aptos_client.ts
AptosGeneratedClient
I opened the same issue on
aptos-core
.The text was updated successfully, but these errors were encountered: