Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add redirect for cli install using windows powershell script #1112

Closed
wants to merge 4 commits into from
Closed

add redirect for cli install using windows powershell script #1112

wants to merge 4 commits into from

Conversation

choir241
Copy link
Contributor

Adds redirect for cli install using windows powershell script

What does this PR do?

Fixes #133

Test Plan

X

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@render Render
Copy link

render bot commented Jul 12, 2024

Your Render PR Server URL is https://appwrite-io-docker-pr-1112.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cq8lomqju9rs73fg8880.

@choir241 choir241 marked this pull request as draft July 12, 2024 16:43
@choir241 choir241 marked this pull request as ready for review July 16, 2024 14:22
@choir241 choir241 requested a review from stnguyen90 July 16, 2024 14:22
stnguyen90
stnguyen90 requested changes Jul 17, 2024
View reviewed changes
src/redirects.json Outdated Show resolved Hide resolved
stnguyen90
stnguyen90 requested changes Jul 17, 2024
View reviewed changes
src/redirects.json Outdated Show resolved Hide resolved
@choir241 choir241 requested a review from stnguyen90 July 18, 2024 16:58
@choir241
Copy link
Contributor Author

choir241 commented Jul 18, 2024 •
edited
Loading

Changed status: 308 to status: 301 in order to make sure iwr -useb https://appwrite.io/cli/install.ps1 | iex works properly for this PR in Windows OS. Since all the redirects were always using status: 308, we need to change it to status: 301 since windows is required to have 301. I confirmed this works after testing it myself on my Windows OS. After making this change, I see the following prompts when I run the command iwr -useb https://appwrite.io/cli/install.ps1 | iex.

Welcome to the Appwrite CLI install shield.
[1/4] Getting System Info ...
[2/4] Downloading Appwrite CLI binary ...
???? Fetching latest version ...



    Directory: C:\Users\userName\AppData\Local


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----         7/17/2024   3:04 PM                Appwrite
[3/4] Starting installation ...
Cleaning up mess ...
[4/4] Finishing Installation ...
Cleaning up mess ...
???? May the force be with you.
To get started with Appwrite CLI, please visit https://appwrite.io/docs/command-line

@stnguyen90
Copy link
Contributor

After talking to @TorstenDittmann, we want to have a proper redirect using a +page.ts endpoint because this redirects.json was only intended to be used for backwards compatibility for old links (Mainly because they are not checked during build).

@stnguyen90 stnguyen90 closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 Awaiting requested review from stnguyen90

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Source not found of powershell script for window
2 participants
@choir241 @stnguyen90