Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more intuitive (Legally satisfactory) values for accepting the License agreement #2325

Open
SalemWafi opened this issue Dec 24, 2024 · 0 comments
Labels
feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged

Comments

@SalemWafi
Copy link

Update the flag value --elv2-license "accept" to accept also the values "yes"/"Yes"/"Y"/"y";
e.g. --elv2-license "yes"

This will provide more intuitive values for most end-users instead of just "accept".

Also, it will still be a satisfactory legal answer to the question, "Do you accept the license agreement of the ELv2 license?"

When that is implemented, these docs need to be updated with this change:


Related issues:

Related Code:
https://github.com/apollographql/rover/blob/6699487c2cae5493bb4ebd93a715a3d53b60ef0f/src/options/license.rs#L77C1-L83C2

@SalemWafi SalemWafi added feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant