generated from apollographql/typescript-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"DeprecationWarning: The punycode
module is deprecated." in Node 22
#331
Comments
Any updates on this? Been having the same issue for a while now... |
I'm having the same issue as well |
Now that Node 22 is LTS, I expect a lot more people will start to see this warning. |
I'm having the same issue. |
1 similar comment
I'm having the same issue. |
I'm having the same issue as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Node version: 22.1.0
@apollo/datasource-rest version: 6.2.2 (latest version at time of writing)
The problem
Since moving to use node 22, we have seen the following deprecation warning:
This will affect everyone using Node 22, which is the Current Node release and will move to LTS on 2024-10-29.
Where it comes from
We have tracked this down to
@apollo/datasource-rest
using"node-fetch": "^2.6.7"
(link) which uses"whatwg-url": "^5.0.0"
(link) which uses the deprecated punycode module.The current version of node-fetch does not depend on
whatwg-url
at all: https://github.com/node-fetch/node-fetch/blob/v3.3.2/package.json#L64. So updating to that version should fix this warning.Node-fetch v3 is an ESM-only package, so that may make the update tricky.
The text was updated successfully, but these errors were encountered: