Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color of logger can be invisible #820

Closed
Jeromearsene opened this issue Oct 27, 2020 · 3 comments
Closed

Color of logger can be invisible #820

Jeromearsene opened this issue Oct 27, 2020 · 3 comments
Labels
feature Issues that represent new features or improvements to existing features.

Comments

@Jeromearsene
Copy link

Jeromearsene commented Oct 27, 2020

I use the Apify logger.
I use iTerm2 on a Macbook. I have Solarized Dark theme.

With this example:

log.info('Page opened:', { label, url });

I have this problem:
Capture d’écran 2020-10-27 à 15 24 55

If I select my text:
Capture d’écran 2020-10-27 à 15 25 16

The logger use same color of my theme for object in log. It is the same issue of this project: unjs/consola#15 (comment)

It is possible to add an option for custom color of logger please ?
Thank you

@Jeromearsene Jeromearsene added the bug Something isn't working. label Oct 27, 2020
@mnmkng
Copy link
Member

mnmkng commented Oct 27, 2020

I don't think we're ready to commit to color customizations, but we'd be willing to allow disabling of colors for situations like this. Would this work for you?

@mnmkng mnmkng added feature Issues that represent new features or improvements to existing features. and removed bug Something isn't working. labels Oct 27, 2020
@Jeromearsene
Copy link
Author

I don't think we're ready to commit to color customizations, but we'd be willing to allow disabling of colors for situations like this. Would this work for you?

That would be very good yes 👍

@mnmkng
Copy link
Member

mnmkng commented Oct 29, 2020

I'll close this in favor of apify/apify-shared-js#82 because that's where the issue belongs.

@mnmkng mnmkng closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues that represent new features or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

2 participants