From d4a905df4a275bcd22938a2343bc0932d3e31dcc Mon Sep 17 00:00:00 2001 From: Eric Pugh Date: Mon, 2 Dec 2024 09:54:10 -0500 Subject: [PATCH] Attempt to clarify why we mention Kerberos and Hadoop Auth in comments --- .../java/org/apache/solr/servlet/SolrDispatchFilter.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java b/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java index 189ebeec134..392fe02ab13 100644 --- a/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java +++ b/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java @@ -325,7 +325,12 @@ private void authenticateRequest( // trivial impl here to keep existing code happy while making the flow clearer. Chain will // be called after this method completes. Eventually auth all moves to its own filter // (hopefully). Most auth plugins simply return true after calling this anyway, so they - // obviously don't care. Kerberos plugins seem to mostly use it to satisfy the api of a + // obviously don't care. + // + // The Hadoop Auth Plugin was removed in SOLR-17540, however leaving the below reference + // for future readers, as there may be an option to simplify this logic. + // + // Kerberos plugins seem to mostly use it to satisfy the api of a // wrapped instance of javax.servlet.Filter and neither of those seem to be doing anything // fancy with the filter chain, so this would seem to be a hack brought on by the fact that // our auth code has been forced to be code within dispatch filter, rather than being a