Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3727]Fix metrics not correct when timeout/connection timeout #4006

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[#3727]Fix metrics not correct when timeout/connection timeout #4006

merged 2 commits into from
Nov 1, 2023

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Nov 1, 2023

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #4006 (c44c39f) into 2.8.x (4ed65bf) will decrease coverage by 0.02%.
The diff coverage is 3.44%.

❗ Current head c44c39f differs from pull request most recent head 693768a. Consider uploading reports for the commit 693768a to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #4006      +/-   ##
============================================
- Coverage     74.23%   74.21%   -0.02%     
  Complexity      703      703              
============================================
  Files          1597     1597              
  Lines         40176    40192      +16     
  Branches       3669     3670       +1     
============================================
+ Hits          29823    29829       +6     
- Misses         8863     8878      +15     
+ Partials       1490     1485       -5
Files Coverage Δ
...ansport/rest/client/http/RestClientInvocation.java 89.11% <100.00%> (-0.15%) ⬇️
...cecomb/transport/rest/client/RestClientSender.java 0.00% <0.00%> (ø)
...b/transport/rest/client/RestClientCodecFilter.java 20.00% <0.00%> (-12.00%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit a2a1c2d into apache:2.8.x Nov 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liubao68 @codecov-commenter