[ISSUE #9133] Credentials enhancement #9134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yx9o
reviewed
Jan 16, 2025
| @@ -0,0 +1,14 @@ | |||
| package org.apache.rocketmq.acl.common; | |||
There was a problem hiding this comment.
Hi, a license is required here.
There was a problem hiding this comment.
The PR has been updated. Thanks for your feedback!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9134 +/- ##
=============================================
+ Coverage 47.93% 47.97% +0.03%
- Complexity 12046 12058 +12
=============================================
Files 1321 1322 +1
Lines 93024 93032 +8
Branches 11926 11926
=============================================
+ Hits 44594 44635 +41
+ Misses 42916 42857 -59
- Partials 5514 5540 +26 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9133
Brief Description
How Did You Test This Change?
Not yet