Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] protobuf-java should be an optional dependency for Pulsar Java client libraries #23469

Open
lhotari opened this issue Oct 16, 2024 · 0 comments
Open

[Bug] protobuf-java should be an optional dependency for Pulsar Java client libraries #23469

lhotari opened this issue Oct 16, 2024 · 0 comments
Labels
triage/lhotari/important lhotari's triaging label for important issues or PRs

Comments

@lhotari
Copy link
Member

lhotari commented Oct 16, 2024 

          > IMO, making protobuf-java optional is beyond the scope of this PR. It’s something worth discussing separately at a later stage.

It was always meant to be optional. It's already optional in the unshaded module. It was included as required dependency by mistake and this is why it's getting included in the shaded jar.

It don't think it's beyond the scope to fix the root cause of the issue.

Originally posted by @merlimat in #23468 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage/lhotari/important lhotari's triaging label for important issues or PRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lhotari