Netbeans cannot delete some text when editing TOML files #8174
Comments
niabot
added
kind:bug
matthiasblaesing
removed
the
needs:triage
|
Reproducible, @lkishalmi @vieiro could you please have a look? |
|
Checking. |
|
Could not reproduce. However there is something weird in the stacktrace above. It has references of |
vieiro
changed the title
|
Hi, I can see what @niabot says. In my case NetBeans does not "hang", but can't delete the last I'll try to take a look at it later on. For the record, here's the message I get in the IDE Log: SEVERE [global]
java.lang.IllegalStateException: Lexer org.netbeans.modules.languages.toml.TomlLexer@419edac2
returned null token but lexerInput.readLength()=2
lexer-state: -1
tokenStartOffset=85, readOffset=87, lookaheadOffset=88
Chars: "\n\n" - these characters need to be tokenized.
Fix the lexer to not return null token in this state.
at org.netbeans.lib.lexer.LexerInputOperation.checkLexerInputFinished(LexerInputOperation.java:435)
at org.netbeans.lib.lexer.LexerInputOperation.nextToken(LexerInputOperation.java:193)
at org.netbeans.lib.lexer.inc.TokenListUpdater.relex(TokenListUpdater.java:602)
at org.netbeans.lib.lexer.inc.TokenListUpdater.updateRegular(TokenListUpdater.java:255)
at org.netbeans.lib.lexer.inc.TokenHierarchyUpdate$UpdateItem.update(TokenHierarchyUpdate.java:325)
at org.netbeans.lib.lexer.inc.TokenHierarchyUpdate.processLevelInfos(TokenHierarchyUpdate.java:200)
at org.netbeans.lib.lexer.inc.TokenHierarchyUpdate.updateImpl(TokenHierarchyUpdate.java:171)
at org.netbeans.lib.lexer.inc.TokenHierarchyUpdate.update(TokenHierarchyUpdate.java:109)
at org.netbeans.lib.lexer.TokenHierarchyOperation.textModified(TokenHierarchyOperation.java:585)
at org.netbeans.spi.lexer.TokenHierarchyControl.textModified(TokenHierarchyControl.java:71)
at org.netbeans.lib.lexer.inc.DocumentInput.textModified(DocumentInput.java:128)
at org.netbeans.lib.lexer.inc.DocumentInput.removeUpdate(DocumentInput.java:121)
at org.netbeans.lib.editor.util.swing.PriorityDocumentListenerList.removeUpdate(PriorityDocumentListenerList.java:91)
at java.desktop/javax.swing.text.AbstractDocument.fireRemoveUpdate(AbstractDocument.java:285)
at org.netbeans.editor.BaseDocument.fireRemoveUpdate(BaseDocument.java:1656)
at org.netbeans.editor.BaseDocument.handleRemove(BaseDocument.java:1026)
at org.netbeans.editor.BaseDocument$FilterBypassImpl.remove(BaseDocument.java:2625)
at java.desktop/javax.swing.text.DocumentFilter.remove(DocumentFilter.java:84)
at org.openide.text.CloneableEditorSupport$DocFilter.remove(CloneableEditorSupport.java:2361)
at org.netbeans.editor.BaseDocument.remove(BaseDocument.java:939)
at org.netbeans.editor.BaseKit$DeleteCharAction$3.run(BaseKit.java:2184)
at org.netbeans.editor.GuardedDocument.runAtomicAsUser(GuardedDocument.java:333)
at org.netbeans.editor.BaseKit$DeleteCharAction.actionPerformed(BaseKit.java:2176)
at org.netbeans.modules.csl.core.CslEditorKit$GsfDeleteCharAction.actionPerformed(CslEditorKit.java:375)
at org.netbeans.editor.BaseAction.actionPerformed(BaseAction.java:324)
at java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1810)
at java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2956)
at java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:3004)
at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2918)
at java.desktop/java.awt.Component.processEvent(Component.java:6398)
at java.desktop/java.awt.Container.processEvent(Container.java:2266)
at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4996)
at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4828)
at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1952)
at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:883)
at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1146)
at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:1020)
at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:848)
at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4877)
at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4828)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:775)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:98)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:747)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:744)
at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:136)
[catch] at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
line 2:0 token recognition error at: '\n'
line 3:0 token recognition error at: '\n' |
|
I think this may happen in any other This does not mean that the |
|
@vieiro The simple example (deleting the last curly brace) did not "hang" Netbeans. But i also managed to get it stuck in an infinite loop by copying/cutting text. This was my workaround for not being able to type or delete a curly brace. This intial bug might have triggered another bug/effect down the line, but i have no stacktrace/exception of it. |
|
Thanks, @niabot . Let us know of any other failures you may be seeing. Not sure if this may go to NB25, though. I think we're almost done with it. |
|
Managed to reproduce. The issue is in the ANTLR Lexer for TOML To reproduce just have the following toml: a = {}then delete the last curly from right with The problem is that ANTLR sends an EOF token in this case, while still having some characters on the stream. I can try to patch the bridge to handle this cases better, though it would be the best to fix the TOML Lexer grammar. |
|
@vieiro I see this PR in your project. vieiro/toml-java#18 That could help. Also each |
|
Thanks @lkishalmi . I'll create a new PR that will help. Basically the lexer will have to return an "error" token whenever an invalid character is found. I'll explain during the weekend. |
|
That'd be a requirement for all |
|
Well, there we go this change INLINE_TABLE_UNEXPECTED : . -> type(INVALID_VALUE), popMode;
INLINE_TABLE_EOF: EOF -> type(INVALID_VALUE), popMode;We may want to update the |
Hi @niabot , the "hang" you are detecting may be due to your specific setup. As @lkishalmi explains you seem to have a |
|
@vieiro @lkishalmi I don't think your assessment is correct, that the user did something special. Have a look here: My reading of this is, that the textmate syntax hightlighter will always run (registered on the empty mimetype). These problem show up at all the locations where the tokensquence is iterated, for the reporter that was syntax highlighting. |
|
Yep, thanks @matthiasblaesing. We couldn't reproduce the hang with the stacktrace provides, if the fix does not solve the problem then we'll need to reopen with a stack trace. |
Apache NetBeans version
Apache NetBeans 24
What happened
When editing TOML files for Gradle projects the editor hangs if there is a temporary syntax error in the files. At first the editor won't let me type anything within unmatched curly braces. Deleting the braces is also not possible. Under some circumstances the entire editor (and netbeans) hangs (endless loop). I get the following or similar exceptions:
Language / Project Type / NetBeans Component
Gradle multi-project
How to reproduce
Copy the following content in the editor (*.toml) and delete the last brace. It wont get deleted because of an exception. Worse can happen if the you add or delete other braces.
Did this work correctly in an earlier version?
No / Don't know
Operating System
Windows 10
JDK
Java 21
Apache NetBeans packaging
Apache NetBeans binary zip
Anything else
No response
Are you willing to submit a pull request?
No
The text was updated successfully, but these errors were encountered: