Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish projects to individual folders rather than publishing the whole solution to one folder (fixes #974) #975

Merged

Conversation

NightOwl888
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Fixes #974

Description

This changes the solution-level publish to output each project into a different folder, which addresses the issue with .NET 7+: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/7.0/solution-level-output-no-longer-valid.

While this has been confirmed to work, it bloats the size of the test artifacts so much that we use 93% of the 10GB allotted on Microsoft hosted build agents: https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#my-pipeline-fails-with-the-error-no-space-left-on-device

This also removes the GitHub workflow that warns when a possible dependency change has been done, which is no longer necessary.

…actZipFileName parameters because they are not in use
…test binaries before uploading as artifacts and to delete them after uploaded to save disk space.
…ild agent after they have been published to the pipeline
@NightOwl888 NightOwl888 changed the title Fix/publish projects not solution 3 Publish projects to individual folders rather than publishing the whole solution to one folder (fixes #974) Oct 20, 2024
@NightOwl888 NightOwl888 merged commit 7f12474 into apache:master Oct 20, 2024
199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Fix the publish process because solution-level publish to a single directory is not supported in .NET 7+
1 participant