From b4e0ad597fd9a88d63fa524e37141426a28c406a Mon Sep 17 00:00:00 2001 From: Bankim Bhavsar Date: Tue, 8 Sep 2020 11:43:38 -0700 Subject: [PATCH] [docs] Remove experimental tag on Bloom filter predicate Impala now supports pushing down Bloom filter predicate to Kudu, by default [1]. Performance testing and associated changes were made to Kudu to reduce regressions when Bloom filter predicate isn't effective [2]. So removing the experimental tag from the C++ client API docs. [1] https://issues.apache.org/jira/browse/IMPALA-3741 [2] https://issues.apache.org/jira/browse/KUDU-3140 Change-Id: I1b87ed5b959de70ab587c1e86eb92a7a84091ce9 Reviewed-on: http://gerrit.cloudera.org:8080/16427 Reviewed-by: Attila Bukor Reviewed-by: Alexey Serbin Tested-by: Bankim Bhavsar (cherry picked from commit 0c4f1f91e3c1ff57360025731f519324a9550730) Reviewed-on: http://gerrit.cloudera.org:8080/16433 Tested-by: Kudu Jenkins --- src/kudu/client/client.h | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/kudu/client/client.h b/src/kudu/client/client.h index 4062c59ba7..40f33c63d7 100644 --- a/src/kudu/client/client.h +++ b/src/kudu/client/client.h @@ -1111,17 +1111,9 @@ class KUDU_EXPORT KuduTable : public sp::enable_shared_from_this { KuduPredicate::ComparisonOp op, KuduValue* value); - /// @name Advanced/Unstable API - /// - /// There are no guarantees on the stability of this client API. - /// - ///@{ - /// Create a new IN Bloom filter predicate which can be used for scanners on /// this table. /// - /// @warning This method is experimental and may change or disappear in future. - /// /// A Bloom filter is a space-efficient probabilistic data structure used to /// test set membership with a possibility of false positive matches. /// See @c KuduBloomFilter for creating Bloom filters. @@ -1153,6 +1145,11 @@ class KUDU_EXPORT KuduTable : public sp::enable_shared_from_this { KuduPredicate* NewInBloomFilterPredicate(const Slice& col_name, std::vector* bloom_filters); + /// @name Advanced/Unstable API + /// + /// There are no guarantees on the stability of this client API. + /// + ///@{ /// Create a new IN Bloom filter predicate using direct BlockBloomFilter /// pointers which can be used for scanners on this table. ///