Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display building numbers #945

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Display building numbers #945

merged 1 commit into from
Feb 3, 2025

Conversation

YongGoose
Copy link
Contributor

Resolves #931

@YongGoose
Copy link
Contributor Author

YongGoose commented Feb 2, 2025

@bchapuis

Due to this issue, I prioritized working on #931

While working on it, I encountered something that needs to be resolved.
I was able to successfully print the building number, but the problem is that the building number is positioned behind the building.

image

I tried applying the addLayer from maplibre, but the building number still appears beneath the building.

@bchapuis
Copy link
Member

bchapuis commented Feb 2, 2025

I think it is mainly a matter of reordering the layers in the main style file. Do not hesitate to play with the order and put legends on top if necessary.

Copy link

sonarqubecloud bot commented Feb 2, 2025

@YongGoose YongGoose marked this pull request as ready for review February 2, 2025 10:51
@YongGoose
Copy link
Contributor Author

I think it is mainly a matter of reordering the layers in the main style file. Do not hesitate to play with the order and put legends on top if necessary.

Thank you so much.

Adjusting the layer order solved the issue.
From now on, I won’t hesitate to experiment with the order freely.

@YongGoose
Copy link
Contributor Author

Could you please check the building number size?

Additionally, when there are multiple numbers for a single building, the numbers don’t appear.
What do you think about this?

OpenStreetMap

image

baremaps

image

I checked the tags of osm_building in the database, and it seems that the building number is missing.

@bchapuis
Copy link
Member

bchapuis commented Feb 3, 2025

Looks good to me 👍 thank you for the contribution. I will open another issue to move the steps in the text-size values for all labels (highways, buildings, etc.) in the default.js theme.

@bchapuis bchapuis merged commit 96cf335 into apache:main Feb 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display building numbers
2 participants