Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl to the iceberg-rest-fixture docker container #11688

Closed
3 tasks
Fokko opened this issue Dec 3, 2024 · 0 comments · Fixed by #11705
Closed
3 tasks

Add curl to the iceberg-rest-fixture docker container #11688

Fokko opened this issue Dec 3, 2024 · 0 comments · Fixed by #11705
Labels
good first issue Good for newcomers improvement PR that improves existing functionality

Comments

@Fokko
Copy link
Contributor

Fokko commented Dec 3, 2024

Feature Request / Improvement

While checking the integration tests on Iceberg-rust (apache/iceberg-rust#748 specifically), it might be nice to add curl to the docker image to enable the health check. With this health check, we no longer have to add logic (we have a loop in Iceberg-rust and a 10-second sleep in PyIceberg) to check if the container is alive and kicking.

Query engine

None

Willingness to contribute

  • I can contribute this improvement/feature independently
  • I would be willing to contribute this improvement/feature with guidance from the Iceberg community
  • I cannot contribute this improvement/feature at this time
@Fokko Fokko added improvement PR that improves existing functionality good first issue Good for newcomers labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement PR that improves existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant