Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parquet bloom filters for UInt8, Int8, UInt16 and Int16 columns #9914

Closed
alamb opened this issue Apr 2, 2024 · 4 comments · Fixed by #9969
Closed

Disable parquet bloom filters for UInt8, Int8, UInt16 and Int16 columns #9914

alamb opened this issue Apr 2, 2024 · 4 comments · Fixed by #9969
Labels
bug Something isn't working good first issue Good for newcomers regression Something that used to work no longer does

Comments

@alamb
Copy link
Contributor

alamb commented Apr 2, 2024

Describe the bug

As @progval discovered, bloom filters on these types return no results (incorrect answers): #9779

Technically I think this is a regression as previously bloom filters on these column types would be ignored

To Reproduce

Not sure (see unit tests for parquet filters, eg. that were added in #9770)

Expected behavior

I think we should disable bloom filters for these types on parquet for now (and maybe update the tests) until we have fixed #9779

Additional context

No response

@alamb alamb added bug Something isn't working good first issue Good for newcomers regression Something that used to work no longer does labels Apr 2, 2024
@progval
Copy link
Contributor

progval commented Apr 2, 2024

Technically I think this is a regression

I agree

as previously bloom filters on these column types would be ignored

only on unsigned columns. they were already not ignored on signed columns.

@alamb
Copy link
Contributor Author

alamb commented Apr 2, 2024

Sounds good -- I think we should still disable bloom filters by default for all types that provide a wrong answer

@edmondop
Copy link
Contributor

edmondop commented Apr 2, 2024

This seems intermediate and maybe I can try it @alamb what do you think?

@alamb
Copy link
Contributor Author

alamb commented Apr 3, 2024

Thanks @edmondop that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers regression Something that used to work no longer does
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants