Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_wider_type in binary.rs does not support utf8view #13360

Open
Tracked by #13504
Omega359 opened this issue Nov 11, 2024 · 2 comments · May be fixed by #13370 or #14378
Open
Tracked by #13504

get_wider_type in binary.rs does not support utf8view #13360

Omega359 opened this issue Nov 11, 2024 · 2 comments · May be fixed by #13370 or #14378
Labels
bug Something isn't working

Comments

@Omega359
Copy link
Contributor

Describe the bug

get_wider_type has support for (LargeUtf8, Utf8) and (Utf8, LargeUtf8) however it's missing support for (LargeUtf8, Utf8View) and (Utf8View, LargeUtf8)

To Reproduce

No response

Expected behavior

get_wider_type properly handles utf8view

Additional context

No response
@Omega359 Omega359 added the bug Something isn't working label Nov 11, 2024
@Omega359 Omega359 mentioned this issue Nov 11, 2024
Closed
6 tasks
@jonathanc-n jonathanc-n linked a pull request Nov 12, 2024 that will close this issue
Open
@alamb alamb mentioned this issue Jan 30, 2025
Open
13 tasks
@alamb
Copy link
Contributor

alamb commented Jan 30, 2025 •
edited
Loading

It turns out the only user of get_wider_type as noted by @jayzhan211 and @Omega359 in #13370 (comment)
So this ticket is really "ensure Utf8View works with array_concat

@alamb alamb linked a pull request Jan 30, 2025 that will close this issue
Open
@alamb
Copy link
Contributor

alamb commented Jan 30, 2025

I tested and array_concat actually already supports Utf8View

Here is a proposed fix for get_wider_type (that deletes it):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@Omega359 @alamb