Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Should we remove pyarrow feature from datafusion core #14197

Open
timsaucer opened this issue Jan 19, 2025 · 2 comments
Open

RFC: Should we remove pyarrow feature from datafusion core #14197

timsaucer opened this issue Jan 19, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@timsaucer
Copy link
Contributor

Is your feature request related to a problem or challenge?

Currently the only place Python interface code exists in the core DataFusion repo is in datafusion/common/src/pyarrow.rs. This contains methods for converting to/from ScalarValue and pyarrow objects. Since datafusion-python repository was split out from the core repo, it may make sense to remove this module. Rust users who want to use these conversions can instead use the datafusion-python, which arguably has far more support for datafusion-python interactions.

Describe the solution you'd like

Remove the pyarrow module and associated features. This would be a breaking change, but likely has extremely little impact on downstream users.

Describe alternatives you've considered

Leave as is, but this prevents things like updating pyo3 downstream. It must stay pinned at the same version as datafusion core.

Additional context

No response

@timsaucer timsaucer added the enhancement New feature or request label Jan 19, 2025
@timsaucer timsaucer changed the title RFC: Should we remove pyarrow from datafusion RFC: Should we remove pyarrow feature from datafusion core Jan 19, 2025
@andygrove
Copy link
Member

This seems logical to me

@Omega359
Copy link
Contributor

agreed, remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants