Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ANSI support for Multiply #534

Open
andygrove opened this issue Jun 6, 2024 · 3 comments · May be fixed by #1135
Open

Add ANSI support for Multiply #534

andygrove opened this issue Jun 6, 2024 · 3 comments · May be fixed by #1135
Assignees
@jatin510
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

Spark has specific handling of overflows when ANSI mode is enabled and we need to add the same in Comet.

Describe the potential solution

No response

Additional context

No response
@andygrove andygrove added the enhancement New feature or request label Jun 6, 2024
@andygrove andygrove mentioned this issue Jun 6, 2024
Open
@andygrove andygrove added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 6, 2024
@jatin510
Copy link
Contributor

Hello @andygrove I would like to work on this issue. Can you please assign it to me

@viirya
Copy link
Member

viirya commented Jun 21, 2024

Thank you @jatin510 . Assigned to you now.

@jatin510
Copy link
Contributor

jatin510 commented Jul 5, 2024

I am planning to implement my solution based on #616 . Will resume once the PR is merged

@dharanad dharanad linked a pull request Dec 4, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jatin510 jatin510

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ANSI support for Add, Subtract & Multiply dharanad/datafusion-comet
3 participants
@viirya @andygrove @jatin510