diff --git a/docs/source/user-guide/configs.md b/docs/source/user-guide/configs.md index d78e6111d..2bea501e5 100644 --- a/docs/source/user-guide/configs.md +++ b/docs/source/user-guide/configs.md @@ -46,6 +46,7 @@ Comet provides the following configuration settings. | spark.comet.exec.filter.enabled | Whether to enable filter by default. | true | | spark.comet.exec.globalLimit.enabled | Whether to enable globalLimit by default. | true | | spark.comet.exec.hashJoin.enabled | Whether to enable hashJoin by default. | true | +| spark.comet.exec.initCap.enabled | Whether to enable initCap by default. | false | | spark.comet.exec.localLimit.enabled | Whether to enable localLimit by default. | true | | spark.comet.exec.memoryPool | The type of memory pool to be used for Comet native execution. Available memory pool types are 'greedy', 'fair_spill', 'greedy_task_shared', 'fair_spill_task_shared', 'greedy_global' and 'fair_spill_global', By default, this config is 'greedy_task_shared'. | greedy_task_shared | | spark.comet.exec.project.enabled | Whether to enable project by default. | true | diff --git a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala index 8c2759a38..039ad1f20 100644 --- a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala +++ b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala @@ -1364,8 +1364,14 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper { sql(s"create table $table(id int, name varchar(20)) using parquet") sql( s"insert into $table values(1, 'james smith'), (2, 'michael rose'), " + - "(3, 'robert williams'), (4, 'rames rose'), (5, 'james smith')") - checkSparkAnswerAndOperator(s"SELECT initcap(name) FROM $table") + "(3, 'robert williams'), (4, 'rames rose'), (5, 'james smith'), " + + "(6, 'robert rose-smith'), (7, 'james ähtäri')") + if (CometConf.COMET_EXEC_INITCAP_ENABLED.get()) { + // TODO: remove this if clause https://github.com/apache/datafusion-comet/issues/1052 + checkSparkAnswerAndOperator(s"SELECT initcap(name) FROM $table") + } else { + checkSparkAnswer(s"SELECT initcap(name) FROM $table") + } } } }