Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Add tests for packages that might be tricky to roundtrip data to Tables + Parquet files #43633

Closed
jonkeane opened this issue Aug 10, 2024 · 1 comment

Comments

@jonkeane
Copy link
Member

Describe the enhancement requested

We recently noticed a problem after revdeps uncovered a lazily read csv with readr failed to roundtrip to parquet. Write tests that will be run in our CI (and setup a job that does this, after installing the extra packages) but that will also not trigger complains in checks or on CRAN since we don't need to or want to actually depend on those packages directly.

Component(s)

R

jonkeane added a commit that referenced this issue Aug 16, 2024
…p data to Tables + Parquet files (#43634)

### Rationale for this change

Add coverage for objects that might have issues roundtripping to Arrow Tables or Parquet files 

### What changes are included in this PR?

A new test file + a crossbow job that ensures these other packages are installed so the tests run.

### Are these changes tested?

The changes are tests

### Are there any user-facing changes?

No
* GitHub Issue: #43633

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
@jonkeane jonkeane added this to the 18.0.0 milestone Aug 16, 2024
@jonkeane
Copy link
Member Author

Issue resolved by pull request 43634
#43634

jonkeane added a commit that referenced this issue Aug 17, 2024
Oops, I should have caught this in #43633 Removes `data.table::` since the namespace is loaded. Also fix some linting errors and free up space on the force tests run.

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant