Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason not to use protobuf-java 3.0.2? #189

Open
jwr opened this issue Aug 16, 2017 · 2 comments
Open

Any reason not to use protobuf-java 3.0.2? #189

jwr opened this issue Aug 16, 2017 · 2 comments

Comments

@jwr
Copy link
Contributor

jwr commented Aug 16, 2017

The current release of clj-rethinkdb (0.15.26) depends on an alpha version of protobuf-java. This clashes with ClojureScript 1.9.854, which will not compile with this version. Adding an exclusion:

[com.apa512/rethinkdb "0.15.26" :exclusions [com.google.protobuf/protobuf-java]]

fixes the problem.

Are there reasons not to use protobuf-java 3.0.2? If not, it is perhaps worth making a release just with updated dependencies. While we're there, I'd also recommend updating the cheshire dependency.

@danielcompton
Copy link
Collaborator

The version on master has a stable protobuf-java version, can you check if that fixes your problems?

@jwr
Copy link
Contributor Author

jwr commented Aug 17, 2017

I don't think there is any need to: I know that exclusion fixes the problems by using 3.0.2, and that the alpha version causes problems. Version 3.0.2 is used by ClojureScript 1.9.854, this is why I'm suggesting moving straight to 3.0.2 instead of 3.0.0 in the master, unless there are reasons not to (which I won't be able to judge quickly just by forcing the version down to 3.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants