Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of byte handling #176

Open
danielcompton opened this issue Aug 14, 2016 · 1 comment
Open

Improve performance of byte handling #176

danielcompton opened this issue Aug 14, 2016 · 1 comment

Comments

@danielcompton
Copy link
Collaborator

There may be more efficient ways to handle the bytes coming and going from RethinkDB than creating and parsing as strings. A few possibilities

  • Look at gloss :char-sequence on the codecs, and if it actually improves performance. We need to handle two types if we go this route, a java.nio.CharBuffer, and a :gloss.data.string.core/char-sequence (both are CharSequences, but the gloss one doesn't give access to the underlying array).
  • Look at using Netty JSON decoding instead
  • Look at using io.netty.handler.codec.protobuf
  • Reusing any resources
  • Parsing the custom RethinkDB types in the JSON parsing
@jwr
Copy link
Contributor

jwr commented Jan 6, 2018

To encourage this: I've been looking at performance problems with clj-rethinkdb recently and from my profiling it appears that gloss.io/decode_stream is a major performance problem.

Additionally, gloss seems to have been abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants