Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing a Manifold stream as another async option #162

Open
danielcompton opened this issue May 14, 2016 · 1 comment
Open

Providing a Manifold stream as another async option #162

danielcompton opened this issue May 14, 2016 · 1 comment

Comments

@danielcompton
Copy link
Collaborator

danielcompton commented May 14, 2016

I've been looking at Manifold, and wondering if it would suit our application's async model better than core.async. What are your thoughts on presenting a Manifold stream as another API option? Perhaps instead of :async? true, you could provide :async? :core-async, or :async? :manifold, with a fallback that :async? true is treated as :core-async. I'm happy to look at this if this idea sounds good.

@apa512
Copy link
Owner

apa512 commented May 14, 2016

Sure. We just have to return the stream directly instead of connecting it to a channel as is done right now:

(let [result-chan (async/chan)]
        (s/connect stream result-chan)
        result-chan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants