Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests #117

Open
50 of 55 tasks
danielcompton opened this issue Nov 20, 2015 · 9 comments
Open
50 of 55 tasks

Add missing tests #117

danielcompton opened this issue Nov 20, 2015 · 9 comments
Labels
easy help wanted hygiene

Comments

@danielcompton
Copy link
Collaborator

danielcompton commented Nov 20, 2015 •
edited
Loading

There are a bunch of query terms that don't have tests. If you're looking to help contribute to the driver, adding tests for some of these would be a great help.

  • index-status
  • index-wait
  • inner-join
  • outer-join
  • eq-join
  • zip
  • with-fields
  • concat-map
  • skip
  • limit
  • slice
  • nth
  • indexes-of
  • is-empty
  • union
  • sample
  • group
  • ungroup
  • reduce
  • count
  • contains
  • pluck
  • append
  • prepend
  • difference
  • set-insert
  • set-union
  • set-intersection
  • set-difference
  • has-fields
  • insert-at
  • splice-at
  • delete-at
  • change-at
  • keys
  • values
  • literal
  • object
  • sub
  • mul
  • div
  • mod
  • not
  • now
  • for-each
  • http
  • desc
  • to-geojson
  • get-intersection
  • get-nearest
  • includes
  • intersects
  • polygon
  • polygon-sub
  • rebalance
danielcompton added a commit that referenced this issue Nov 21, 2015
@danielcompton
Add tests for object, keys, values
892003d 
Relates to #117
anthonygalea pushed a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 15, 2016
Add tests for sub, mul, div, mod, not. Relates to apa512#117.
1cf0cff
anthonygalea pushed a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 17, 2016
Add tests for now, to-geojson, includes, intersects, polygon, polygon…
b9a876c 
…-sub. Relates to apa512#117.
@anthonygalea anthonygalea mentioned this issue Apr 17, 2016
Merged
anthonygalea pushed a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 18, 2016
Add tests for set-insert, set-union, set-intersection, set-difference…
f0db63e 
…. Relates to apa512#117.
@anthonygalea anthonygalea mentioned this issue Apr 18, 2016
Merged
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 19, 2016
@anthonygalea
Add tests for append, prepend, difference, insert-at, splice-at, dele…
aedbbf9 
…te-at, change-at. Relates to apa512#117.
@anthonygalea anthonygalea mentioned this issue Apr 19, 2016
Merged
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 20, 2016
@anthonygalea
Add tests for pluck, has-fields. Releates to apa512#117.
b8c50a9
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 20, 2016
@anthonygalea
Add tests for pluck, has-fields. Relates to apa512#117.
9452046
danielcompton added a commit that referenced this issue Apr 20, 2016
@danielcompton
Merge pull request #144 from anthonygalea/master
067ddcd 
Add tests for pluck, has-fields. Relates to #117.
anthonygalea pushed a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 23, 2016
Add tests for contains, coerce-to. Relates to apa512#117.
8e19533
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 23, 2016
@anthonygalea
Add tests for contains, coerce-to. Relates to apa512#117.
cc3cd16
apa512 added a commit that referenced this issue Apr 23, 2016
@apa512
Merge pull request #146 from anthonygalea/master
9fa90c3 
Add tests for contains, coerce-to. Relates to #117.
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 24, 2016
@anthonygalea
Add tests for skip, limit, slice, sample. Relates to apa512#117.
6d708d9
apa512 added a commit that referenced this issue Apr 24, 2016
@apa512
Merge pull request #147 from anthonygalea/master
59d022f 
Add tests for skip, limit, slice, sample. Relates to #117.
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 26, 2016
@anthonygalea
Add tests for nth, is-empty, union. Relates to apa512#117.
16a793f
apa512 added a commit that referenced this issue Apr 27, 2016
@apa512
Merge pull request #148 from anthonygalea/master
698e7d4 
Add tests for nth, is-empty, union. Relates to #117.
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue Apr 27, 2016
@anthonygalea
Rename indexes-of to offsets-of. Add tests for offsets-of. Relates to a…
f70c285 
…pa512#117.
danielcompton added a commit that referenced this issue Apr 29, 2016
@danielcompton
Merge pull request #149 from anthonygalea/master
a308584 
Rename indexes-of to offsets-of. Add tests for offsets-of. Relates to #117.
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue May 4, 2016
@anthonygalea
Add tests for group, ungroup, count, distinct. Relates to apa512#117.
a6e066e
danielcompton added a commit that referenced this issue May 4, 2016
@danielcompton
Merge pull request #152 from anthonygalea/master
b58b1c8 
Add tests for group, ungroup, count, distinct. Relates to #117.
@danielytics
Copy link
Contributor

@anthonygalea Thanks for your awesome work on this! 👍

@bhurlow
Copy link

bhurlow commented May 4, 2016

woooo!

@lukaszkorecki
Copy link

@anthonygalea so much ❤️ for this

@anthonygalea
Copy link
Contributor

my pleasure

anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue May 5, 2016
@anthonygalea
Renamed get-intersection to get-intersecting. Added tests for get-int…
00bfa5f 
…ersecting, get-nearest. Relates to apa512#117.
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue May 9, 2016
@anthonygalea
Add tests for index-status, index-wait. Relates to apa512#117.
09e7f7d
danielcompton added a commit that referenced this issue May 9, 2016
@danielcompton
Merge pull request #156 from anthonygalea/master
a920a1e 
Add tests for index-status, index-wait. Relates to #117.
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue May 10, 2016
@anthonygalea
Add tests for reduce, http. Relates to apa512#117.
a15cc2b
danielcompton added a commit that referenced this issue May 11, 2016
@danielcompton
Merge pull request #157 from anthonygalea/master
d80d745 
Add tests for reduce, http. Relates to #117.
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue May 13, 2016
@anthonygalea
Add tests for desc, with-fields, concat-map. Relates to apa512#117.
e961ae5
anthonygalea added a commit to anthonygalea/clj-rethinkdb that referenced this issue May 13, 2016
@anthonygalea
Add tests for desc, with-fields, concat-map. Relates to apa512#117.
22ddfe6
danielcompton added a commit that referenced this issue May 13, 2016
@danielcompton
Merge pull request #159 from anthonygalea/master
547d273 
Add tests for desc, with-fields, concat-map. Relates to #117.
@ds2643
Copy link

ds2643 commented Sep 26, 2016 •
edited
Loading

Hi all, I'm interested in helping. Is the above checklist still up to date?

@danielcompton
Copy link
Collaborator Author

It should be close, though there might be some for joins.

@DonyorM
Copy link
Contributor

DonyorM commented Dec 27, 2016

I'm going to try and work on this a little, anything I need to know about?

@DonyorM DonyorM mentioned this issue Jan 1, 2017
Merged
@danielcompton
Copy link
Collaborator Author

@DonyorM should be pretty close to up to date, leave a comment here if there's anything missed though.

@DonyorM
Copy link
Contributor

DonyorM commented Jan 2, 2017

@danielcompton Ok thank you. I submitted a pull request adding some of the joins tests. I believe someone also added a test for the eq-joins tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy help wanted hygiene
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lukaszkorecki @danielcompton @anthonygalea @bhurlow @danielytics @DonyorM @ds2643