Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-5 Throw automatic errors if authors submits screenshots which are not png #38

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

jmetrikat
Copy link
Member


  • I understand that contributing to this repository will require me to agree with the CLA

Description

If screenshots are not png format, label "changes_requested" and comment about the problem are added.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

https://linear.app/anytype/issue/GH-5/throw-automatic-errors-if-authors-submits-screenshots-which-are-not

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@fuksman
Copy link
Member

fuksman commented Jan 28, 2024

@any contributor @jmetrikat tooling

any-bot bot added a commit to anyproto/contributors that referenced this pull request Jan 28, 2024
@fuksman fuksman merged commit 1d780d4 into anyproto:main Jan 28, 2024
fuksman pushed a commit to anyproto/contributors that referenced this pull request Jan 28, 2024
* Add @jmetrikat for tooling (requested in anyproto/gallery#37)

* Add @jmetrikat for tooling (requested in anyproto/gallery#38)

---------

Co-authored-by: any-bot[bot] <140514579+any-bot[bot]@users.noreply.github.com>
@jmetrikat jmetrikat deleted the gh-5-screenshot-format-png branch January 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants