Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace indent doesn't reset if a call throws an error #14

Open
antross opened this issue Aug 14, 2018 · 0 comments
Open

Trace indent doesn't reset if a call throws an error #14

antross opened this issue Aug 14, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@antross
Copy link
Owner

antross commented Aug 14, 2018

This leads to the indent increasing with each error produced by the page, even if the error is in a try/catch block.

I think I might fix this by using a callback approach to log the data (passed to the Trace constructor) so the callback can be wrapped in try/finally (with finally removing the indent).

@antross antross added the bug Something isn't working label Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant