-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does CrabNet use the validation data to improve the model? #15
Comments
It shouldn't, if it did that then that dataset would become training data
and not validation.
|
Good point. I think I've been a bit confused as to whether sometimes people use "validation data" to adjust hyperparameters of the model (in some sense I think we all do this, but maybe a bit more manually as we run models while debugging/developing), hence the idea of a third "test" set. Just wanted to make sure. I agree with your definition. Thanks Anthony! |
Ok, I think my suspicion is confirmed (validation data is used to improve CrabNet's training results). I had been looking and wondering where the validation set may have been used during the training process, and I found somewhere in Lines 115 to 119 in e884482
Near the end of training (not sure why this is on the 2nd to last epoch instead of the last epoch), it goes into L273: Lines 272 to 273 in e884482
See PyTorch 1.6 now includes Stochastic Weight Averaging (blog) Recently, I came to an error where |
Empirical testsEmpirical tests also seem to confirm this (similar to my question about using "dummy" validation data). 1. Using validation data to calculate
|
For example, as it is progressing through epochs, would the results change at all if dummy validation were supplied instead of "true" validation data?
The text was updated successfully, but these errors were encountered: