Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preemptively remove django-taggit relationships #14238

Open
4 of 9 tasks
AlanCoding opened this issue Jul 13, 2023 · 0 comments
Open
4 of 9 tasks

Preemptively remove django-taggit relationships #14238

AlanCoding opened this issue Jul 13, 2023 · 0 comments

Comments

@AlanCoding
Copy link
Member

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.

Feature type

New Feature

Feature Summary

Task, do the following:

  • remove taggit use in awx/main/models, mainly in the form of taggit.managers.TaggableManager
  • run awx-manage makemigrations

Any existing tags will be deleted in this process.

Why? Because with jazzband/django-taggit#862 there is a lot of uncertainty about whether this library will play nicely with future Django versions, and whether it will do so in the time frame that we need it. Django has made some opinionated changes that requires a degree of synchronicity, in that the old pattern of index_together will stop working at some point, but the new pattern isn't supported by 3.Y versions. The library may increase their minimum version, or it may introduce long-term versions for 3 vs 4 Django versions. Either way, I'm not counting on that happening.


For the future, when (or if) the Django upgrade forces us to remove the taggit library, this will leave the option open to declare the current AWX version as a checkpoint version, and then in the next version:

  • Manually delete the taggit tables at the start of the migration command or some other way, or do this as SQL in another numbered migration
  • Also manually as a separate step, run awx-manage remove_stale_contenttypes, or maybe do that in a numbered migration

Select the relevant components

  • UI
  • API
  • Docs
  • Collection
  • CLI
  • Other

Steps to reproduce

N/A

Current results

N/A

Sugested feature result

N/A

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants