Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensearch - Remove CurrentState attribute #2162

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

opensearch - Remove CurrentState attribute #2162

wants to merge 3 commits into from

Conversation

ichekaldin
Copy link
Contributor

SUMMARY

This is necessary because describe_domain_config method returns both CurrentState and DesiredState while update_domain_config method only expects DesiredState.

Fixes #2161.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

opensearch

ADDITIONAL INFORMATION

@ichekaldin
fix: Remove CurrentState attribute
6a8748f 
This is necessary because describe_domain_config method returns both CurrentState and DesiredState
while update_domain_config method only expects DesiredState.
@ichekaldin
Add changelog fragment
4eb37bc
@ichekaldin
fix: Changelog fragment file name
92d0d15
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/583c9489b40945f6b4c9e0ce8dcfce69

❌ ansible-galaxy-importer FAILURE in 5m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 15s
✔️ ansible-test-splitter SUCCESS in 4m 23s
Skipped 22 jobs

@markuman
Copy link
Member

Can you also please add an integration test that covers this case? https://github.com/ansible-collections/community.aws/tree/main/tests/integration/targets/opensearch

Otherwise LGTM

@ichekaldin
Copy link
Contributor Author

@markuman, as far as I can tell, integration tests for opensearch are disabled.

I'm fairly certain the existing tests would catch it by failing.

I'm not exactly sure when this piece of Opensearch functionality was introduced. I suspect it happened between April 25, 2024 (which is the most recent successful build of my Ansible automation that touched Opensearch) and now.

@markuman
Copy link
Member

markuman commented Oct 1, 2024

@markuman, as far as I can tell, integration tests for opensearch are disabled.

Ah ok. I'll run the opensearch test locally later this day and give you a feedback.

@ichekaldin
Copy link
Contributor Author

@markuman, any luck with the testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opensearch Module Fails to Update Existing Domains
2 participants
@ichekaldin @markuman