Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a rewards address when claiming rewards #3965

Open
nick-u410 opened this issue Oct 31, 2024 · 2 comments
Open

Support a rewards address when claiming rewards #3965

nick-u410 opened this issue Oct 31, 2024 · 2 comments
Labels
enhancement New feature or request PoS

Comments

@nick-u410
Copy link

When claiming validator rewards, we’d prefer these rewards not to be directed to a hot wallet(connected to the internet), as they currently are. Instead, it would be ideal to set a designated rewards address so that, upon claiming, the rewards are sent directly to a cold wallet(not connected to the internet), minimizing any risk associated with holding funds in a hot wallet.

A few ideas on how to implement

  • We could allow setting a rewards address when initing a validator. When you claim rewards, they are sent to this address. This would require validator metadata changes, etc. Not the most flexible approach.
  • Another approach could be to allow setting the rewards address when running the claim rewards command. This would allow users to switch rewards address per claim if they choose to do so.
  • Auto restaking rewards at the protocol level should still work as it does today, meaning by setting a rewards address, we do not want all rewards to immediately flow to this address.
@nick-u410 nick-u410 added the enhancement New feature or request label Oct 31, 2024
@sug0
Copy link
Contributor

sug0 commented Oct 31, 2024

this is already supported. in the cli of claim-rewards, pass --source <address-to-receive-rewards>
nevermind, source is some account where the bond originated from, so it is true we can't withdraw to a diff address

@sug0 sug0 closed this as completed Oct 31, 2024
@brentstone brentstone reopened this Oct 31, 2024
@brentstone
Copy link
Collaborator

brentstone commented Oct 31, 2024

@sug0 I don't think that is true. The source one must provide is the owner of the bond for which rewards are being claimed - it is typically the user who is submitting the tx.

@brentstone brentstone added the PoS label Oct 31, 2024
@brentstone brentstone added this to the Future breaking upgrade milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PoS
Projects
None yet
Development

No branches or pull requests

3 participants