Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Some issues in dccd #40

Open
vicb opened this issue Jun 10, 2014 · 2 comments
Open

Some issues in dccd #40

vicb opened this issue Jun 10, 2014 · 2 comments

Comments

@vicb
Copy link
Contributor

vicb commented Jun 10, 2014

this code has some issues:

  • hashCode is a property of Objects in Dart - not sure if it's applicables to JS,
  • not all modes have _MODE_NAMES (10, 11)
@caitp
Copy link
Contributor

caitp commented Jun 10, 2014

Thanks @vicb

@caitp
Copy link
Contributor

caitp commented Jun 10, 2014

@EisenbergEffect I think I mentioned this before, but the NOTIFIED and NOT_NOTIFIED modes are more like boolean flags, these probably shouldn't live in mode, but I don't think this ever was justified. Anyways, I'm not going to add names for them right now, but that should probably be cleaned up or at least explained more clearly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants