Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Update project to gulp-sass@5 #12114

Closed
Splaktar opened this issue Jul 5, 2021 · 1 comment · Fixed by #12131
Closed

Update project to gulp-sass@5 #12114

Splaktar opened this issue Jul 5, 2021 · 1 comment · Fixed by #12131
Assignees
Labels
P2: required Issues that must be fixed. type: build
Milestone

Comments

@Splaktar
Copy link
Member

Splaktar commented Jul 5, 2021

Discuss the use-case or motivation for changing the existing behavior

This is blocked by #12113 as gulp-sass@5 requires gulp@4.

One of the reasons we need to support the new sass package is mentioned in PR #12112:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($button-fab-height - $button-fab-padding, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
345 │   @include fab-position(bottom-right, auto, ($button-fab-width - $button-fab-padding)/2, ($button-fab-height - $button-fab-padding)/2, auto);
    │                                                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    node_modules\angular-material\angular-material.scss 345:90  fab-all-positions()
    node_modules\angular-material\angular-material.scss 2000:5  @import

List the affected versions of AngularJS, Material, OS, and browsers

  • AngularJS: 1.8.2
  • AngularJS Material: 1.2.3
  • OS: all
  • Browsers: all
  • Screen Readers: all

Add anything else we should know

Here's the migration guide: https://github.com/dlmanning/gulp-sass#migrating-to-version-5

@Splaktar Splaktar added type: bug needs triage Issues that need initial triage P2: required Issues that must be fixed. type: build and removed needs triage Issues that need initial triage type: bug labels Jul 5, 2021
@Splaktar Splaktar added this to the 1.2.4 milestone Jul 5, 2021
@Splaktar Splaktar added the Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. label Jul 5, 2021
@Splaktar Splaktar modified the milestones: 1.2.4, - Backlog Oct 28, 2021
Splaktar added a commit that referenced this issue Nov 18, 2021
@Splaktar Splaktar self-assigned this Nov 18, 2021
@Splaktar Splaktar modified the milestones: - Backlog, 1.2.4 Nov 18, 2021
@Splaktar Splaktar removed the Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. label Nov 18, 2021
@Splaktar
Copy link
Member Author

Splaktar commented Nov 18, 2021

Based on PR #12131, this doesn't seem to be blocked by gulp@4 afterall.

Splaktar added a commit that referenced this issue Nov 19, 2021
Splaktar added a commit that referenced this issue Nov 19, 2021
Splaktar added a commit that referenced this issue Nov 22, 2021
Splaktar added a commit that referenced this issue Nov 23, 2021
superheri pushed a commit to superheri/material that referenced this issue Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2: required Issues that must be fixed. type: build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant