Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can you tell me why Application Context is used in ViewModel? #19

Open
easyhooon opened this issue Jan 29, 2024 · 5 comments · May be fixed by #39
Open

Can you tell me why Application Context is used in ViewModel? #19

easyhooon opened this issue Jan 29, 2024 · 5 comments · May be fixed by #39
Assignees
@donovanfm

Comments

@easyhooon
Copy link

easyhooon commented Jan 29, 2024 •
edited
Loading

https://github.com/android/socialite/blob/main/app/src/main/java/com/google/android/samples/socialite/ui/camera/CameraViewModel.kt
https://github.com/android/socialite/blob/main/app/src/main/java/com/google/android/samples/socialite/ui/videoedit/VideoEditScreenViewModel.kt

I'm curious about the reason for directly handling Toast message events in the ViewModel by injecting the Application Context, especially since it's possible to handle these events in the view using Channel, SharedFlow, or StateFlow.(Using a method of emitting and collecting to events)

As this approach is used in the official Android sample repository, does it imply that injecting the Application Context into the ViewModel and handling context-required operations directly within the ViewModel is more recommended than the previously mentioned three methods?
@hoc081098
Copy link

I have the same think.
Toast should be showed in the View side

@donovanfm donovanfm self-assigned this Jan 31, 2024
@donovanfm
Copy link
Contributor

Hi, thanks for taking a look at our sample! I will update the ViewModels to move away from passing in the Context. Great catch!

@donovanfm donovanfm linked a pull request Mar 20, 2024 that will close this issue
Open
@yongsuk44 yongsuk44 mentioned this issue Mar 21, 2024
Open
@Jaehwa-Noh
Copy link

@easyhooon why are you closing this?

@easyhooon easyhooon reopened this Jan 10, 2025
@easyhooon
Copy link
Author

easyhooon commented Jan 10, 2025 •
edited
Loading

@Jaehwa-Noh I came back after a while to check if it was resolved, and when I looked at the code, I thought the issue was fixed since it seemed the Toast calling method had been changed to not inject the Application Context into the viewModel. If it's still not resolved, I'll keep it open!

I see that it's still not resolved for the VideoEditScreenViewModel

@Jaehwa-Noh
Copy link

I beriefly check it and can't find toast logic, but it still passed application context into ViewModel.
Basically application context is longer lived than viewModel so that I concerned. Is this pattern could be allow in this viewModel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donovanfm donovanfm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Toast invocations out of Camera/VideoEdit ViewModels. android/socialite
4 participants
@donovanfm @hoc081098 @Jaehwa-Noh @easyhooon